This is an automated email from the ASF dual-hosted git repository.

xudong963 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 1d5b2cac8f Fix flaky test case in joins.slt (#16849)
1d5b2cac8f is described below

commit 1d5b2cac8f0424b7eba3f5c885c9f2cbf1ad008e
Author: Piotr Findeisen <[email protected]>
AuthorDate: Tue Jul 22 14:05:18 2025 +0200

    Fix flaky test case in joins.slt (#16849)
    
    The query lacks total ordering, added `t1_name, t2_name` to ORDER BY,
    consistent with preceding test cases.
---
 datafusion/sqllogictest/test_files/joins.slt | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/datafusion/sqllogictest/test_files/joins.slt 
b/datafusion/sqllogictest/test_files/joins.slt
index 6c40a71fa6..d426627274 100644
--- a/datafusion/sqllogictest/test_files/joins.slt
+++ b/datafusion/sqllogictest/test_files/joins.slt
@@ -725,24 +725,24 @@ SELECT t1_id, t1_name, t2_name FROM t1, t2 WHERE 1=1 
ORDER BY t1_id, t1_name, t2
 44 d z
 
 query ITT nosort
-SELECT t1_id, t1_name, t2_name FROM t1 CROSS JOIN t2 ORDER BY t1_id
+SELECT t1_id, t1_name, t2_name FROM t1 CROSS JOIN t2 ORDER BY t1_id, t1_name, 
t2_name
 ----
-11 a z
-11 a y
-11 a x
 11 a w
-22 b z
-22 b y
-22 b x
+11 a x
+11 a y
+11 a z
 22 b w
-33 c z
-33 c y
-33 c x
+22 b x
+22 b y
+22 b z
 33 c w
-44 d z
-44 d y
-44 d x
+33 c x
+33 c y
+33 c z
 44 d w
+44 d x
+44 d y
+44 d z
 
 query ITITI rowsort
 SELECT * FROM (SELECT t1_id, t1_name FROM t1 UNION ALL SELECT t1_id, t1_name 
FROM t1) AS t1 CROSS JOIN t2
@@ -5064,7 +5064,7 @@ physical_plan
 05)--------DataSourceExec: partitions=1, partition_sizes=[0]
 06)--------DataSourceExec: partitions=1, partition_sizes=[10000]
 
-query II 
+query II
 SELECT *
 FROM t2
 WHERE k2 > 0


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to