This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 9c116a5959 ci: fix temporary file creation in tests and tighten CI
check (#18374)
9c116a5959 is described below
commit 9c116a595979fd45aed5b2aa233fa3bc25a7d3a4
Author: Yongting You <[email protected]>
AuthorDate: Thu Oct 30 14:26:41 2025 +0800
ci: fix temporary file creation in tests and tighten CI check (#18374)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
Temporary file is created during test, see reproducer in
`datafusion-cli`
```sh
yongting@Yongtings-MacBook-Pro-2 ~/C/datafusion (main=)> cargo test
--package datafusion --test core_integration --all-features --
dataframe::test_copy_schema --exact --nocapture
Compiling datafusion v50.3.0
(/Users/yongting/Code/datafusion/datafusion/core)
Finished `test` profile [unoptimized + debuginfo] target(s) in 2.50s
Running tests/core_integration.rs
(target/debug/deps/core_integration-dee3896b38f536b2)
running 1 test
test dataframe::test_copy_schema ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 801 filtered
out; finished in 0.02s
yongting@Yongtings-MacBook-Pro-2 ~/C/datafusion (main=)> git status
On branch main
Your branch is up to date with 'upstream/main'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
"datafusion/core/\"/"
nothing added to commit but untracked files present (use "git add" to track)
```
This PR fixes this test, and make CI stricter for similar temporary file
creations.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Yes, I have run the CI without fix in my local repo, it's failing as
expected:
https://github.com/2010YOUY01/arrow-datafusion/actions/runs/18913128118/job/53989721867
After the fix, the CI should be able to pass.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
---
.github/workflows/rust.yml | 9 +++++++++
datafusion/core/tests/dataframe/mod.rs | 2 +-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 7019de0b75..8a3563899f 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -302,6 +302,15 @@ jobs:
--features
serde,avro,json,backtrace,integration-tests,parquet_encryption
- name: Verify Working Directory Clean
run: git diff --exit-code
+ # Check no temporary directories created during test.
+ # `false/` folder is excuded for rust cache.
+ - name: Verify Working Directory Clean (No Untracked Files)
+ run: |
+ STATUS="$(git status --porcelain | sed -e '/^?? false\/$/d' -e '/^??
false$/d')"
+ if [ -n "$STATUS" ]; then
+ echo "$STATUS"
+ exit 1
+ fi
# datafusion-cli tests
linux-test-datafusion-cli:
diff --git a/datafusion/core/tests/dataframe/mod.rs
b/datafusion/core/tests/dataframe/mod.rs
index e27a341485..c35e3b2eb3 100644
--- a/datafusion/core/tests/dataframe/mod.rs
+++ b/datafusion/core/tests/dataframe/mod.rs
@@ -6328,7 +6328,7 @@ async fn test_copy_schema() -> Result<()> {
let target_path = tmp_dir.path().join("target.csv");
let query = format!(
- "COPY source_table TO '{:?}' STORED AS csv",
+ "COPY source_table TO '{}' STORED AS csv",
target_path.to_str().unwrap()
);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
