This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new f2437d13c0 Disable `parquet_encryption` by default in
datafusion-sqllogictests (#18492)
f2437d13c0 is described below
commit f2437d13c08283cb1dd1241b716c4e3a4e027648
Author: Qi Zhu <[email protected]>
AuthorDate: Thu Nov 6 11:17:54 2025 +0800
Disable `parquet_encryption` by default in datafusion-sqllogictests (#18492)
## Which issue does this PR close?
- Closes [#18490](https://github.com/apache/datafusion/issues/18490)
## Rationale for this change
When our internal project to use datafusion, we found it default to
enable encryption even for latest datafusion.
Problem Analysis
In datafusion/sqllogictest/Cargo.toml:
```rust
datafusion = { workspace = true, default-features = true, features =
["avro", "parquet_encryption"] }
```
The Problem:
datafusion-sqllogictest depends on datafusion with default-features =
true
And, sqllogictest is the member of datafusion, it will default to
encryption when we use datafusion.
```rust
[workspace]
members = [
"datafusion/common",
"datafusion/common-runtime",
"datafusion/catalog",
"datafusion/catalog-listing",
"datafusion/datasource",
"datafusion/datasource-avro",
"datafusion/datasource-csv",
"datafusion/datasource-json",
"datafusion/datasource-parquet",
"datafusion/core",
"datafusion/expr",
"datafusion/expr-common",
"datafusion/execution",
"datafusion/ffi",
"datafusion/functions",
"datafusion/functions-aggregate",
"datafusion/functions-aggregate-common",
"datafusion/functions-table",
"datafusion/functions-nested",
"datafusion/functions-window",
"datafusion/functions-window-common",
"datafusion/optimizer",
"datafusion/physical-expr",
"datafusion/physical-expr-adapter",
"datafusion/physical-expr-common",
"datafusion/physical-optimizer",
"datafusion/pruning",
"datafusion/physical-plan",
"datafusion/proto",
"datafusion/proto/gen",
"datafusion/proto-common",
"datafusion/proto-common/gen",
"datafusion/session",
"datafusion/spark",
"datafusion/sql",
"datafusion/sqllogictest",
"datafusion/substrait",
"datafusion-cli",
"datafusion-examples",
"datafusion-examples/examples/ffi/ffi_example_table_provider",
"datafusion-examples/examples/ffi/ffi_module_interface",
"datafusion-examples/examples/ffi/ffi_module_loader",
"test-utils",
"benchmarks",
"datafusion/macros",
"datafusion/doc",
]
exclude = ["dev/depcheck"]
resolver = "2"
```
## What changes are included in this PR?
Fixed above.
## Are these changes tested?
Yes
## Are there any user-facing changes?
Make encryption a feature instead of default.
---
.github/workflows/extended.yml | 2 +-
.github/workflows/rust.yml | 2 +-
datafusion/sqllogictest/Cargo.toml | 5 ++++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/extended.yml b/.github/workflows/extended.yml
index 2472d2e042..19d3e723c6 100644
--- a/.github/workflows/extended.yml
+++ b/.github/workflows/extended.yml
@@ -169,7 +169,7 @@ jobs:
rust-version: stable
- name: Run sqllogictest
run: |
- cargo test --features backtrace --profile release-nonlto --test
sqllogictests -- --include-sqlite
+ cargo test --features backtrace,parquet_encryption --profile
release-nonlto --test sqllogictests -- --include-sqlite
cargo clean
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 88d9f4e133..4b3c31e6b3 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -475,7 +475,7 @@ jobs:
export RUST_MIN_STACK=20971520
export TPCH_DATA=`realpath
datafusion/sqllogictest/test_files/tpch/data`
cargo test plan_q --package datafusion-benchmarks --profile ci
--features=ci -- --test-threads=1
- INCLUDE_TPCH=true cargo test --features backtrace --profile ci
--package datafusion-sqllogictest --test sqllogictests
+ INCLUDE_TPCH=true cargo test --features backtrace,parquet_encryption
--profile ci --package datafusion-sqllogictest --test sqllogictests
- name: Verify Working Directory Clean
run: git diff --exit-code
diff --git a/datafusion/sqllogictest/Cargo.toml
b/datafusion/sqllogictest/Cargo.toml
index e719a8851d..9cf3972701 100644
--- a/datafusion/sqllogictest/Cargo.toml
+++ b/datafusion/sqllogictest/Cargo.toml
@@ -43,7 +43,7 @@ bigdecimal = { workspace = true }
bytes = { workspace = true, optional = true }
chrono = { workspace = true, optional = true }
clap = { version = "4.5.50", features = ["derive", "env"] }
-datafusion = { workspace = true, default-features = true, features = ["avro",
"parquet_encryption"] }
+datafusion = { workspace = true, default-features = true, features = ["avro"] }
datafusion-spark = { workspace = true, default-features = true }
datafusion-substrait = { workspace = true, default-features = true }
futures = { workspace = true }
@@ -78,6 +78,9 @@ postgres = [
"testcontainers-modules",
"tokio-postgres",
]
+parquet_encryption = [
+ "datafusion/parquet_encryption",
+]
[dev-dependencies]
env_logger = { workspace = true }
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
