This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 5053c71af6 Update docs for aggregate repartition test (#18650)
5053c71af6 is described below

commit 5053c71af6f0d10608a242c1c4b2712e9300173b
Author: Xander <[email protected]>
AuthorDate: Thu Nov 13 04:43:54 2025 -0500

    Update docs for aggregate repartition test (#18650)
    
    ## Which issue does this PR close?
    Test was updated in
    
https://github.com/apache/datafusion/pull/18521/files#diff-fe22c0d1093b8b848a9317b0796f58276d36b98c8444865dcc0c252fd5b02632R102
    but docs don't reflect the new plan.
    <!--
    We generally require a GitHub issue to be filed for all bug fixes and
    enhancements and this helps us generate change logs for our releases.
    You can link an issue to this PR using the GitHub syntax. For example
    `Closes #123` indicates that this PR will close issue #123.
    -->
    
    - Closes #.
    
    ## Rationale for this change
    
    <!--
    Why are you proposing this change? If this is already explained clearly
    in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand
    your changes and offer better suggestions for fixes.
    -->
    
    ## What changes are included in this PR?
    Only doc changes for tests.
    <!--
    There is no need to duplicate the description in the issue here but it
    is sometimes worth providing a summary of the individual changes in this
    PR.
    -->
    
    ## Are these changes tested?
    
    <!--
    We typically require tests for all PRs in order to:
    1. Prevent the code from being accidentally broken by subsequent changes
    2. Serve as another way to document the expected behavior of the code
    
    If tests are not included in your PR, please explain why (for example,
    are they covered by existing tests)?
    -->
    
    ## Are there any user-facing changes?
    No
    
    <!--
    If there are user-facing changes then we may require documentation to be
    updated before approving the PR.
    -->
    
    <!--
    If there are any breaking changes to public APIs, please add the `api
    change` label.
    -->
    
    Co-authored-by: Xander <[email protected]>
---
 datafusion/sqllogictest/test_files/aggregate_repartition.slt | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/datafusion/sqllogictest/test_files/aggregate_repartition.slt 
b/datafusion/sqllogictest/test_files/aggregate_repartition.slt
index 7612fc84d4..5db26f00a7 100644
--- a/datafusion/sqllogictest/test_files/aggregate_repartition.slt
+++ b/datafusion/sqllogictest/test_files/aggregate_repartition.slt
@@ -84,9 +84,6 @@ physical_plan
 07)------------DataSourceExec: file_groups={1 group: 
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/aggregate_repartition/dim.csv]]},
 projection=[env], file_type=csv, has_header=true
 
 # Test 2: EXPLAIN query for Parquet table with GROUP BY
-# This plan differs from the one above and includes two consecutive 
repartitions — one round-robin and one hash —
-# which seems unnecessary. We may want to align it with the previous plan 
(push the round robin down or remove the round robin), or, if the input file is 
small,
-# avoid repartitioning altogether. A single partition should suffice for a 
single-step aggregate as the plan after this.
 
 query TT
 EXPLAIN SELECT env, count(*) FROM dim_parquet GROUP BY env;


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to