This is an automated email from the ASF dual-hosted git repository.
agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new 5f204c9be feat: support cot (#2755)
5f204c9be is described below
commit 5f204c9be70256bca934d93a5fce3b71f0692538
Author: Vrishabh <[email protected]>
AuthorDate: Fri Nov 14 01:09:34 2025 +0530
feat: support cot (#2755)
---
docs/source/user-guide/latest/expressions.md | 1 +
fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala | 1 +
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala | 1 +
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala | 3 ++-
4 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/docs/source/user-guide/latest/expressions.md
b/docs/source/user-guide/latest/expressions.md
index 548941f7a..a8e110c86 100644
--- a/docs/source/user-guide/latest/expressions.md
+++ b/docs/source/user-guide/latest/expressions.md
@@ -128,6 +128,7 @@ incompatible expressions.
| BRound | `bround` | Yes |
|
| Ceil | `ceil` | Yes |
|
| Cos | `cos` | Yes |
|
+| Cot | `cot` | Yes |
|
| Divide | `/` | Yes |
|
| Exp | `exp` | Yes |
|
| Expm1 | `expm1` | Yes |
|
diff --git a/fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala
b/fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala
index 5e921df26..2e29cb930 100644
--- a/fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala
+++ b/fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala
@@ -114,6 +114,7 @@ object Meta {
createUnaryNumericFunction("sin"),
createUnaryNumericFunction("sqrt"),
createUnaryNumericFunction("tan"),
+ createUnaryNumericFunction("cot"),
createUnaryNumericFunction("ceil"),
createUnaryNumericFunction("floor"),
createFunctionWithInputTypes("unary_minus", Seq(SparkNumericType)))
diff --git a/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
b/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
index 44890c1c9..1d46d544b 100644
--- a/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
+++ b/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
@@ -115,6 +115,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
classOf[Sqrt] -> CometScalarFunction("sqrt"),
classOf[Subtract] -> CometSubtract,
classOf[Tan] -> CometScalarFunction("tan"),
+ classOf[Cot] -> CometScalarFunction("cot"),
classOf[UnaryMinus] -> CometUnaryMinus,
classOf[Unhex] -> CometUnhex,
classOf[Abs] -> CometAbs)
diff --git a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
index fc45d2cb3..9f00c3903 100644
--- a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
@@ -1352,7 +1352,8 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
"log2",
"sin",
"sqrt",
- "tan")) {
+ "tan",
+ "cot")) {
val (_, cometPlan) =
checkSparkAnswerAndOperatorWithTol(sql(s"SELECT $expr(_1), $expr(_2)
FROM tbl"))
val cometProjectExecs = collect(cometPlan) { case op: CometProjectExec
=>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
