This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new e6d1773ef5 chore: Add missing boolean tests to `bit_count` Spark
function (#18871)
e6d1773ef5 is described below
commit e6d1773ef5c91b7f86c6a6dd57928f645402f757
Author: Oleks V <[email protected]>
AuthorDate: Fri Nov 21 10:11:33 2025 -0800
chore: Add missing boolean tests to `bit_count` Spark function (#18871)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
Follow up on https://github.com/apache/datafusion/pull/18841
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Adding missing bool tests for bit_count
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
---
.../sqllogictest/test_files/spark/bitwise/bit_count.slt | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/datafusion/sqllogictest/test_files/spark/bitwise/bit_count.slt
b/datafusion/sqllogictest/test_files/spark/bitwise/bit_count.slt
index 216d990251..e07c96d7c1 100644
--- a/datafusion/sqllogictest/test_files/spark/bitwise/bit_count.slt
+++ b/datafusion/sqllogictest/test_files/spark/bitwise/bit_count.slt
@@ -225,3 +225,18 @@ query I
SELECT bit_count(arrow_cast(-9223372036854775808, 'Int64'));
----
1
+
+query I
+SELECT bit_count(true);
+----
+1
+
+query I
+SELECT bit_count(false);
+----
+0
+
+query I
+SELECT bit_count(cast(null as boolean));
+----
+NULL
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
