This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 2bea796897 Minor: remove unnecessary unit tests for fixed size binary
(#19318)
2bea796897 is described below
commit 2bea7968977fd9e2f78c766ca553a45068c15048
Author: Andrew Lamb <[email protected]>
AuthorDate: Sun Dec 14 23:24:09 2025 -0500
Minor: remove unnecessary unit tests for fixed size binary (#19318)
## Which issue does this PR close?
- Follow on to https://github.com/apache/datafusion/pull/18950
## Rationale for this change
Per @timsaucer 's comment
https://github.com/apache/datafusion/pull/18950#discussion_r2608304739
> Ok to remove now that we have SLT.
These unit tests duplicate coverage we have with SLT so let's remove
them to avoid redundancy
## What changes are included in this PR?
remove duplicate tests added
https://github.com/apache/datafusion/pull/18950
## Are these changes tested?
by ci
## Are there any user-facing changes?
No
---
datafusion/functions/src/encoding/inner.rs | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/datafusion/functions/src/encoding/inner.rs
b/datafusion/functions/src/encoding/inner.rs
index d60c39a25d..7eed40dcc8 100644
--- a/datafusion/functions/src/encoding/inner.rs
+++ b/datafusion/functions/src/encoding/inner.rs
@@ -574,29 +574,3 @@ fn decode(args: &[ColumnarValue]) -> Result<ColumnarValue>
{
}?;
decode_process(expression, encoding)
}
-
-#[cfg(test)]
-mod tests {
- #[test]
- fn test_encode_fsb() {
- use super::*;
-
- let value = vec![0u8; 16];
- let array =
arrow::array::FixedSizeBinaryArray::try_from_sparse_iter_with_size(
- vec![Some(value)].into_iter(),
- 16,
- )
- .unwrap();
- let value = ColumnarValue::Array(Arc::new(array));
-
- let ColumnarValue::Array(result) =
- encode_process(&value, Encoding::Base64).unwrap()
- else {
- panic!("unexpected value");
- };
-
- let string_array =
result.as_any().downcast_ref::<StringArray>().unwrap();
- let result_value = string_array.value(0);
- assert_eq!(result_value, "AAAAAAAAAAAAAAAAAAAAAA");
- }
-}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
