This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 65a6bc4231 chore: use extend instead of manual loop in multi group by
(#19429)
65a6bc4231 is described below
commit 65a6bc423142678528cdde03e4e2823952758328
Author: Raz Luvaton <[email protected]>
AuthorDate: Sun Dec 21 06:18:36 2025 +0200
chore: use extend instead of manual loop in multi group by (#19429)
## Which issue does this PR close?
N/A
## Rationale for this change
using more efficient extend
## What changes are included in this PR?
replace manual loop with `extend`
## Are these changes tested?
existing tests
## Are there any user-facing changes?
Nope
---
.../src/aggregates/group_values/multi_group_by/mod.rs | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
a/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs
b/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs
index 4c9e376fc4..479bff001e 100644
--- a/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs
+++ b/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs
@@ -540,14 +540,13 @@ impl<const STREAMING: bool> GroupValuesColumn<STREAMING> {
// into `vectorized_equal_to_row_indices` and
`vectorized_equal_to_group_indices`.
let list_offset = group_index_view.value() as usize;
let group_index_list = &self.group_index_lists[list_offset];
- for &group_index in group_index_list {
- self.vectorized_operation_buffers
- .equal_to_row_indices
- .push(row);
- self.vectorized_operation_buffers
- .equal_to_group_indices
- .push(group_index);
- }
+
+ self.vectorized_operation_buffers
+ .equal_to_group_indices
+ .extend_from_slice(group_index_list);
+ self.vectorized_operation_buffers
+ .equal_to_row_indices
+ .extend(std::iter::repeat_n(row, group_index_list.len()));
} else {
let group_index = group_index_view.value() as usize;
self.vectorized_operation_buffers
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
