leerho commented on a change in pull request #129:
URL:
https://github.com/apache/datasketches-memory/pull/129#discussion_r637257594
##########
File path: src/main/java/org/apache/datasketches/memory/BaseState.java
##########
@@ -152,43 +70,30 @@ public final boolean equals(final Object that) {
* @return true if the given object has equal contents to this object in the
given range of
* bytes.
*/
- public final boolean equalTo(final long thisOffsetBytes, final Object that,
- final long thatOffsetBytes, final long lengthBytes) {
- return that instanceof BaseState
- ? CompareAndCopy.equals(this, thisOffsetBytes, (BaseState) that,
thatOffsetBytes, lengthBytes)
- : false;
- }
-
+ boolean equalTo(long thisOffsetBytes, Object that,
+ long thatOffsetBytes, long lengthBytes);
+
Review comment:
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]