jmalkin commented on code in PR #63:
URL:
https://github.com/apache/datasketches-postgresql/pull/63#discussion_r1177122042
##########
src/cpc_sketch_pg_functions.c:
##########
@@ -286,7 +368,6 @@ Datum pg_cpc_sketch_union(PG_FUNCTION_ARGS) {
cpc_sketch_delete(sketchptr2);
}
sketchptr = cpc_union_get_result(unionptr);
- cpc_union_delete(unionptr);
Review Comment:
Unclear why this was removed? It'll be cleaned up at the end of the
transaction, but it seems to have been a temporary local variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
