leerho commented on code in PR #447:
URL: https://github.com/apache/datasketches-java/pull/447#discussion_r1290452858
##########
src/main/java/org/apache/datasketches/sampling/ReservoirItemsSketch.java:
##########
@@ -259,7 +259,7 @@ public static <T> ReservoirItemsSketch<T> heapify(final
Memory srcMem,
final int itemsToRead = (int) Math.min(k, itemsSeen);
final T[] data = serDe.deserializeFromMemory(
- srcMem.region(preLongBytes, srcMem.getCapacity() - preLongBytes),
itemsToRead);
+ srcMem.region(preLongBytes, srcMem.getCapacity() - preLongBytes), 0,
itemsToRead);
Review Comment:
You are correct. My modification only made the error go away, I should have
replaced the use of region entirely. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
