github-advanced-security[bot] commented on code in PR #546:
URL: https://github.com/apache/datasketches-java/pull/546#discussion_r1563102510
##########
src/test/java/org/apache/datasketches/quantilescommon/PartitionBoundariesTest.java:
##########
@@ -196,6 +196,40 @@
assertEquals(minItm, "1");
}
+ @Test(expectedExceptions = SketchesArgumentException.class)
+ public void checkSketchPartitionLimits() {
+ final long totalN = 1_000_000;
+ final Comparator<String> comparator = Comparator.naturalOrder();
+ final ArrayOfStringsSerDe serDe = new ArrayOfStringsSerDe();
+ final KllItemsSketch<String> sk =
KllItemsSketch.newHeapInstance(comparator, serDe);
+ final int d = digits(totalN);
+ for (int i = 1; i <= totalN; i++) {
+ sk.update(getString(i, d));
+ }
+ final int numLimit = sk.getMaxPartitions();
+ final int ret = sk.getNumRetained();
+ println("ret: " + ret + ", numLimit " + numLimit);
+ @SuppressWarnings("unused")
+ GenericPartitionBoundaries<String> gpb =
sk.getPartitionBoundariesFromNumParts(numLimit + 1);
Review Comment:
## Unread local variable
Variable 'GenericPartitionBoundaries<String> gpb' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/713)
##########
src/test/java/org/apache/datasketches/quantilescommon/PartitionBoundariesTest.java:
##########
@@ -196,6 +196,40 @@
assertEquals(minItm, "1");
}
+ @Test(expectedExceptions = SketchesArgumentException.class)
+ public void checkSketchPartitionLimits() {
+ final long totalN = 1_000_000;
+ final Comparator<String> comparator = Comparator.naturalOrder();
+ final ArrayOfStringsSerDe serDe = new ArrayOfStringsSerDe();
+ final KllItemsSketch<String> sk =
KllItemsSketch.newHeapInstance(comparator, serDe);
+ final int d = digits(totalN);
+ for (int i = 1; i <= totalN; i++) {
+ sk.update(getString(i, d));
+ }
+ final int numLimit = sk.getMaxPartitions();
+ final int ret = sk.getNumRetained();
+ println("ret: " + ret + ", numLimit " + numLimit);
+ @SuppressWarnings("unused")
+ GenericPartitionBoundaries<String> gpb =
sk.getPartitionBoundariesFromNumParts(numLimit + 1);
+ }
+
+ @Test(expectedExceptions = SketchesArgumentException.class)
+ public void checkSketchPartitionLimits2() {
+ final long totalN = 1_000_000;
+ final Comparator<String> comparator = Comparator.naturalOrder();
+ final ArrayOfStringsSerDe serDe = new ArrayOfStringsSerDe();
+ final KllItemsSketch<String> sk =
KllItemsSketch.newHeapInstance(comparator, serDe);
+ final int d = digits(totalN);
+ for (int i = 1; i <= totalN; i++) {
+ sk.update(getString(i, d));
+ }
+ final long sizeLimit= sk.getMinPartitionSizeItems();
+
+ println("Min Size Limit: " + sizeLimit);
+ @SuppressWarnings("unused")
+ GenericPartitionBoundaries<String> gpb =
sk.getPartitionBoundariesFromPartSize(sizeLimit - 1);
Review Comment:
## Unread local variable
Variable 'GenericPartitionBoundaries<String> gpb' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/714)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
