github-advanced-security[bot] commented on code in PR #546:
URL: https://github.com/apache/datasketches-java/pull/546#discussion_r1564481233
##########
src/test/java/org/apache/datasketches/quantilescommon/PartitionBoundariesTest.java:
##########
@@ -196,6 +199,65 @@
assertEquals(minItm, "1");
}
+ @SuppressWarnings("unused")
+ @Test //For visual check, set enablePrinting = true to view.
+ public void checkSketchPartitionLimits() {
+ final long totalN = 2000; //1_000_000;
+ final Comparator<String> comparator = Comparator.naturalOrder();
+ final ArrayOfStringsSerDe serDe = new ArrayOfStringsSerDe();
+ final int k = 1 << 15;
+ final KllItemsSketch<String> sk = KllItemsSketch.newHeapInstance(k,
comparator, serDe);
+ final int d = digits(totalN);
+ for (int i = 1; i <= totalN; i++) {
+ sk.update(getString(i, d));
+ }
+ //***
+ final int numRet = sk.getNumRetained();
+ println("NumRetained: " + numRet + " /2: " + (numRet / 2));
+ final double eps = sk.getNormalizedRankError(true);
+ printf("NormRankErr: %10.6f 1/eps: %10.3f" + LS, eps, 1/eps);
+ //***
+ //this should pass
+ final int goodNumPartsRequest = sk.getMaxPartitions();
+ println("Good numPartsRequest " + goodNumPartsRequest);
+ GenericPartitionBoundaries<String> gpb =
sk.getPartitionBoundariesFromNumParts(goodNumPartsRequest);
Review Comment:
## Unread local variable
Variable 'GenericPartitionBoundaries<String> gpb' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/715)
##########
src/test/java/org/apache/datasketches/quantilescommon/PartitionBoundariesTest.java:
##########
@@ -196,6 +199,65 @@
assertEquals(minItm, "1");
}
+ @SuppressWarnings("unused")
+ @Test //For visual check, set enablePrinting = true to view.
+ public void checkSketchPartitionLimits() {
+ final long totalN = 2000; //1_000_000;
+ final Comparator<String> comparator = Comparator.naturalOrder();
+ final ArrayOfStringsSerDe serDe = new ArrayOfStringsSerDe();
+ final int k = 1 << 15;
+ final KllItemsSketch<String> sk = KllItemsSketch.newHeapInstance(k,
comparator, serDe);
+ final int d = digits(totalN);
+ for (int i = 1; i <= totalN; i++) {
+ sk.update(getString(i, d));
+ }
+ //***
+ final int numRet = sk.getNumRetained();
+ println("NumRetained: " + numRet + " /2: " + (numRet / 2));
+ final double eps = sk.getNormalizedRankError(true);
+ printf("NormRankErr: %10.6f 1/eps: %10.3f" + LS, eps, 1/eps);
+ //***
+ //this should pass
+ final int goodNumPartsRequest = sk.getMaxPartitions();
+ println("Good numPartsRequest " + goodNumPartsRequest);
+ GenericPartitionBoundaries<String> gpb =
sk.getPartitionBoundariesFromNumParts(goodNumPartsRequest);
+ //this should fail
+ try {
+ final int badNumPartsRequest = goodNumPartsRequest + 1;
+ println("Bad numPartsRequest " + badNumPartsRequest);
+ gpb = sk.getPartitionBoundariesFromNumParts(badNumPartsRequest);
+ fail("Bad numPartsRequest should have failed. " + badNumPartsRequest);
+ } catch (SketchesArgumentException e) { } //OK
+ }
+
+ @SuppressWarnings("unused")
+ @Test //For visual check, set enablePrinting = true to view.
+ public void checkSketchPartitionLimits2() {
+ final long totalN = 2000; //1_000_000;
+ final Comparator<String> comparator = Comparator.naturalOrder();
+ final ArrayOfStringsSerDe serDe = new ArrayOfStringsSerDe();
+ final int k = 1 << 15;
+ final KllItemsSketch<String> sk = KllItemsSketch.newHeapInstance(k,
comparator, serDe);
+ final int d = digits(totalN);
+ for (int i = 1; i <= totalN; i++) {
+ sk.update(getString(i, d));
+ }
+ final double eps = sk.getNormalizedRankError(true);
+ printf("NormRankErr: %10.6f 1/eps: %10.3f" + LS, eps, 1/eps);
+ println("N: " + sk.getN());
+ println("Max Parts: " + sk.getMaxPartitions());
+
+ //this should pass
+ final long goodPartSizeRequest= sk.getMinPartitionSizeItems();
+ println("Good partSizeRequest " + goodPartSizeRequest);
+ GenericPartitionBoundaries<String> gpb =
sk.getPartitionBoundariesFromPartSize(goodPartSizeRequest);
Review Comment:
## Unread local variable
Variable 'GenericPartitionBoundaries<String> gpb' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/716)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
