leerho opened a new pull request, #179: URL: https://github.com/apache/datasketches-memory/pull/179
As reported in issue #178: > static Memory wrap(byte[] array, int offsetBytes, int lengthBytes, ByteOrder byteOrder) ... > ... > return BaseWritableMemoryImpl.wrapHeapArray(array, **_0_**, lengthBytes, true, ByteOrder.nativeOrder(), null); The "0" in the return statement should have been "offsetBytes". I checked the similar classes WritableMemory, Buffer and WritableBuffer for a similar error and they were all OK. This fix includes a test for this bug. When approved this will be merged into branch 2.2.X in preparation for a bug fix release 2.2.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
