Copilot commented on code in PR #274:
URL:
https://github.com/apache/datasketches-memory/pull/274#discussion_r2866910281
##########
.github/workflows/auto-jdk-os-matrix.yml:
##########
@@ -6,66 +6,40 @@ on:
branches: [ 'main', '[0-9]+.[0-9]+.[Xx]', 'v[0-9]+.[0-9]+.[Xx]']
pull_request:
paths-ignore: [ '**/*.html', '**/*.md', '**/*.txt', '**/LICENSE',
'**/NOTICE' ]
- # The branches below must be a subset of the branches above
branches: [ 'main', '[0-9]+.[0-9]+.[Xx]', 'v[0-9]+.[0-9]+.[Xx]']
- workflow_dispatch:
+ workflow_dispatch:
-env:
- MAVEN_OPTS: -Xmx4g -Xms1g
- MAVEN_ARGS: "-B -Dmaven.javadoc.skip=true -Dgpg.skip=true"
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
jobs:
- build:
- name: Build, Test, Install
- runs-on: ${{ matrix.os }}
-
+ run-matrix:
strategy:
fail-fast: false
matrix:
jdk: [ 25 ]
- os: [ windows-latest, ubuntu-latest, macos-latest ]
-
+ include:
+ - os: windows-latest
+ arch: x64
+ - os: ubuntu-latest
+ arch: x64
+ - os: macos-latest
+ arch: aarch64
Review Comment:
The matrix is currently defined with only a `jdk` axis plus `include`
entries that add `os`/`arch` but do not specify `jdk`. In GitHub Actions this
produces an extra default job with no `matrix.os`/`matrix.arch`, and the
included jobs may not have `matrix.jdk` set, causing the reusable workflow
inputs (`jdk_version`, `os_type`, `java_arch`) to be empty/undefined. Define
`os` as a real matrix axis (and map `arch` via `include`), or move `jdk` into
each `include` entry (and drop the separate `jdk` axis) so every matrix row has
all required keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
