leerho commented on PR #466: URL: https://github.com/apache/datasketches-cpp/pull/466#issuecomment-5923089429
I'm closing this PR. - It's a whole new sketch: 5,000 lines across 37 files. - It still requires C++20. The November review said the base repo must stay C++11-compatible. The author agreed to convert it, but no new code has appeared since. - CI has been failing since January, and the November changes-requested review is still open. - It will need a new review once this repo has been refactored. DDSketch's serialization will be a new path for untrusted bytes, so it will need the same malformed-input testing as #520. - The author was warned on Sept 23, and there's been no reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
