jaideeppyne commented on issue #460: URL: https://github.com/apache/datasketches-cpp/issues/460#issuecomment-5925244897
Thank you, Lee, for the careful verification and for carrying these fixes through. It is great to see all four behaviors aligned, and the table makes the final state very clear. I also appreciate the acknowledgement of the differential analysis.\n\nRegarding the harness: I cleaned up the scratch workspace after the investigation, so I no longer have the exact scripts I ran and do not want to present an unverified reconstruction as the original artifact.\n\nFor reference, the matrix covered empty and single-item sketches, exact and estimation modes, sampling with p < 1, union, intersection, A-not-B, ordered and unordered compact forms, default and alternate seeds, and v4 compressed serialization. Each case compared the serialized bytes, retained count, theta, estimate, and upper/lower bounds across Java and C++.\n\nIf a repository-native version would still be useful for the CLB work, I would be happy to reconstruct it against current Java main and C++ master, rerun the full matrix , and contribute it in the test location and format you prefer.\n\nThanks again for closing the loop and getting these fixes into 5.3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
