leerho commented on PR #532: URL: https://github.com/apache/datasketches-cpp/pull/532#issuecomment-5938947361
Thanks @jaideeppyne, this is a good addition: it turns the existing Java compatibility test into a byte-level regression check for the #460 fixes. I ran it locally against the Java snapshots in datasketches-tck, and all 15 cases match. **One request:** the change switches these tests from the stream deserialize(is) to the byte-buffer deserialize(ptr, size), so the stream path loses its coverage against Java files. Could you deserialize both ways and check they agree? We are planning on restructuring the C++ library for a 6.0.0 release, and as part of that we will be moving cross-language fixtures to datasketches-tck (https://github.com/apache/datasketches-tck), where each language's generators produce .sk snapshots that the other implementations consume. New cases (set-operation results, p < 1, alternate seeds, unordered) would be added as generators in datasketches-java and datasketches-cpp, with consumer tests here. Since the test layout will change in 6.0.0, please hold off on rebuilding the matrix until we've set up the TCK structure. We'll ping you here when it's ready. Very soon we will be creating a 5.3.0 release, so if you could respond quickly to the above request, we may be able to fit it in. In short: the #532 change now for 5.3.0, and the matrix after the restructure in master, before 6.0.0. How does that sound? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
