stojkomilos commented on PR #567: URL: https://github.com/apache/datasketches-cpp/pull/567#issuecomment-6854363608
@leerho > Timing: this changes the results users get, so it belongs in a minor release, not in the bug-fix release we're finishing now. We're holding other PRs until that release is out. Do you know approximately when this bug-fix release and this minor release are coming out? Order of magnitude > 1. Sorted view lifetime. As you noted, for non-arithmetic types the view now points at the min and max inside the sketch object, so a view held across a move of the sketch no longer works. That fits the existing rule, as in Java, that a sorted view shouldn't be used after the sketch changes, but in C++ that rule isn't written down, and the failure is silent. Could you add it to the `get_sorted_view()` documentation in both sketches, saying that for non-arithmetic types the view refers to the sketch's items and must not be used after the sketch is updated, merged, moved or destroyed? Done. > 2\. REQ. With this PR, KLL and classic quantiles match Java, but REQ doesn't. I'd like to see the REQ follow-up you offered planned alongside this, so all three sketches change in the same release. Moving REQ `get_rank()` to the sorted view is a reasonable way to do it. Actually I decided against this, and doing only for KLL. Let me know if you disagree. The reason I changed my mind, is that i reworked most of the PR (due to the performance issues), and now it's a bit more complex, so I think it's a bit easier to review it this way after the rework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
