likyh commented on issue #2744: URL: https://github.com/apache/incubator-devlake/issues/2744#issuecomment-1216595033
@e2corporation > 1. This is old code you are referencing, The `OnSettings` change here has been wrapped in an if check to ensure that configured board is defined so "undefined" board objects are not created. This interaction is just fine. > 2. `configuredBoard` and `configuredProject` are defined in the DSM hook. It lives at parent level, does not need to be only defined in child component DataTransformations. It's not enough to check if configuredBoard is undefined. Son component should not add new connections between the parent's state and the parent's callback. Maybe here we can call onSettingsChange only when typeMappingAll loaded and changed by user. Now configuredBoard changed in the parent component will lead to an unexcepted update in the parent component sight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
