likyh opened a new issue, #3331: URL: https://github.com/apache/incubator-devlake/issues/3331
## What and why to refactor https://github.com/apache/incubator-devlake/blob/7b0199a6d8557d4f18b73200d619a96d10df0163/config-ui/src/hooks/useConnectionManager.jsx#L646-L708 We shouldn't export casually. It will cause us confusion about where the state is used. Especially we should export the set functions carefully. If export, we must use more time to know where it will use. The most confusing is that `setIsSaving` and `setAllTestResponses` are exported. I don't think it will be used out of the hook. I also don't think it should be used out of the hook. `isSaving` and `allTestResponses` is only can set by the HTTP request. So it cannot be exported. ## Describe the solution you'd like Read and try to delete all unused and unnecessary export of set functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
