e2corporation commented on issue #3334: URL: https://github.com/apache/incubator-devlake/issues/3334#issuecomment-1273244581
@likyh I think a majority of the problem here is your interpretation of how Effects should work. There are times when a func will have callback args, and other times where a Setter is not needed as a dependency but that depends on the _context_ of how the effect is being used and how the developer is implementing the flow. If you encounter a loop problem going forward, you simply troubleshoot it and fix related dependencies to resolve the issue. If adding a required dependency causes loop, then look closer at the dependency itself whether it's a setter func or some other generic constant that simply needs a callback wrap to solve the problem. The comment about using a an Object prop rather than the whole object is well documented by react, and also by the article I shared. I mentioned that to give you a better understanding of nuances when using Objects as a dependency. In some cases we want the whole object, in other cases we only need a single prop like `Object?.id`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
