e2corporation commented on code in PR #3496:
URL: 
https://github.com/apache/incubator-devlake/pull/3496#discussion_r1013021179


##########
config-ui/src/components/blueprints/ProviderTransformationSettings.jsx:
##########
@@ -84,7 +82,20 @@ const ProviderTransformationSettings = (props) => {
     provider?.id && TransformationComponents[provider?.id]
       ? TransformationComponents[provider?.id]
       : null,
-    { ...props, entities: props.entities[props?.connection?.id] }
+    {
+      dataDomains: dataDomainsGroup[connection?.id],
+      provider,

Review Comment:
   One of the reasons for using the HOC function is so that spreading 
`...props` is much cleaner and less code, and there will be no need to maintain 
these props manually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to