warren830 commented on code in PR #3700:
URL:
https://github.com/apache/incubator-devlake/pull/3700#discussion_r1017485585
##########
plugins/jenkins/tasks/build_cicd_convertor.go:
##########
@@ -102,7 +107,7 @@ func ConvertBuildsToCICD(taskCtx core.SubTaskContext) (err
errors.Error) {
Id:
buildIdGen.Generate(jenkinsBuild.ConnectionId,
jenkinsBuild.FullDisplayName),
},
- Name: jenkinsBuild.JobName,
+ Name: fmt.Sprintf(`%s%s`,
jenkinsBuild.JobPath, jenkinsBuild.JobName),
Review Comment:
To reviewer: I'm not quite sure if we should do this concat. Maybe we can
use jobName directly as we will have cicd_scope_id to bind this pipeline to the
right cicd_scope(jenkins job)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
