keon94 commented on code in PR #4839:
URL:
https://github.com/apache/incubator-devlake/pull/4839#discussion_r1155076209
##########
backend/core/migration/migrator.go:
##########
@@ -84,10 +89,9 @@ func (m *migratorImpl) Execute() errors.Error {
})
// execute them one by one
db := m.basicRes.GetDal()
- logger := m.basicRes.GetLogger().Nested("migrator")
for _, swc := range m.pending {
- scriptId := fmt.Sprintf("%d-%s", swc.script.Version(),
swc.script.Name())
Review Comment:
this cache key (%d-%s) was inconsistent with the key format used in the rest
of the code (%s:%d). This is a bug, right? @klesh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
