CamilleTeruel commented on issue #4986: URL: https://github.com/apache/incubator-devlake/issues/4986#issuecomment-1525192023
> So basically have the server make a shell call to a script that returns the plugin details, rather than the plugins calling back into the server? Exactly, python plugins are loaded by walking `REMOTE_PLUGIN_DIR` looking for `run.sh` executables just after loading go plugins in `loader.go`. > This can work but you also have to worry about the custom file descriptor we use and correctly propagating that from Go to Shell to Python. I don't think that's trivial. This still uses invoker and bridge abstraction that take care of the extra file descriptor. > Also, If we're going to do a mass refactor, I honestly think we should just move away from cmd calls and have python run as a separate RPC service. This is not a mass refactor. This is just changing plugin registration flow. I agree that we should move away from cmd calls. This change is a necessary first step in that direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
