CamilleTeruel commented on code in PR #6627:
URL:
https://github.com/apache/incubator-devlake/pull/6627#discussion_r1426745896
##########
backend/python/plugins/azuredevops/azuredevops/streams/builds.py:
##########
@@ -87,10 +87,11 @@ def convert(self, b: Build, ctx: Context):
cicd_scope_id=ctx.scope.domain_id(),
)
- yield devops.CiCDPipelineCommit(
- pipeline_id=b.domain_id(),
- commit_sha=b.source_version,
- branch=b.source_branch,
- repo_id=ctx.scope.domain_id(),
- repo_url=ctx.scope.url,
- )
+ if b.source_version is not None:
+ yield devops.CiCDPipelineCommit(
Review Comment:
Do we want to also skip the Pipeline above if there is no corresponding
commit?
@klesh Should we keep a pipeline that failed for reasons external to the
code changes (here a connection issue with github)? I'm asking because the
decision might affect downstream metrics.
Otherwise LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
