d4x1 commented on code in PR #7032: URL: https://github.com/apache/incubator-devlake/pull/7032#discussion_r1504243418
########## backend/python/pydevlake/pydevlake/model.py: ########## @@ -125,13 +128,17 @@ def set_tool_origin(self, tool_model: 'ToolModel'): class NoPKModel(RawDataOrigin): - created_at: Optional[datetime] = Field( + created_at: [datetime] = Field( Review Comment: 1. `created_at`should be optional, argeed. 2. I haven't find any appropriate method to replace `session.merge()`, fortunately `created_at` is not very neccessary so far. I think we should just leave it as it's for the present. loading and merging manually is so ungraceful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
