d4x1 commented on code in PR #7325:
URL:
https://github.com/apache/incubator-devlake/pull/7325#discussion_r1566684732
##########
backend/plugins/gitlab/models/pipeline.go:
##########
@@ -58,6 +58,7 @@ type GitlabPipelineProject struct {
PipelineId int `gorm:"primaryKey"`
ProjectId int `gorm:"primaryKey"`
Ref string `gorm:"type:varchar(255)"`
+ WebUrl string `gorm:"type:varchar(255)"`
Review Comment:
varchar(255) maybe too short.
##########
backend/core/models/domainlayer/devops/cicd_deployment.go:
##########
@@ -25,6 +25,8 @@ type CICDDeployment struct {
domainlayer.DomainEntity
CicdScopeId string `gorm:"index;type:varchar(255)"`
Name string `gorm:"type:varchar(255)"`
+ DisplayTitle string
Review Comment:
If you don't specify a gorm type, it's will be varchar(256) by default.
It doesn't affect functionality, but it's just inconsistent.
##########
backend/plugins/bamboo/e2e/deploy_build_test.go:
##########
@@ -102,11 +102,11 @@ func TestBambooDeployBuildDataFlow(t *testing.T) {
dataflowTester.VerifyTableWithOptions(&devops.CicdDeploymentCommit{},
e2ehelper.TableOptions{
CSVRelPath: "./snapshot_tables/cicd_deployment_commits.csv",
IgnoreTypes: []interface{}{common.NoPKModel{}},
- IgnoreFields: []string{},
+ IgnoreFields: []string{"created_date", "queued_date",
"started_date", "finished_date"},
Review Comment:
Why ignore these fields ? I think they are useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
