klesh commented on code in PR #7459:
URL:
https://github.com/apache/incubator-devlake/pull/7459#discussion_r1601122909
##########
backend/plugins/azuredevops_go/api/connection_api.go:
##########
@@ -79,17 +73,23 @@ func TestExistingConnection(input *plugin.ApiResourceInput)
(*plugin.ApiResource
if err != nil {
return nil, errors.BadInput.Wrap(err, "can't read connection
from database")
}
-
- vsc := azuredevops.NewClient(connection, nil,
"https://app.vssps.visualstudio.com/";)
- _, err = vsc.GetUserProfile()
- if err != nil {
+ var updatedConn models.AzuredevopsConn
Review Comment:
Consider using the `dsHelper.ConnApi.GetMergedConnection` which would fetch
the connection from the database and patch it up.
https://github.com/apache/incubator-devlake/blob/3e589c9f2d4902e1ad48d03fc0b3d06966cde81b/backend/plugins/jira/api/connection_api.go#L153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
