(incubator-devlake) branch main updated: refactor: CollectAccounts now uses simple ApiCollector (#8067)

[klesh]

This is an automated email from the ASF dual-hosted git repository.

klesh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/main by this push:
     new 3367db446 refactor: CollectAccounts now uses simple ApiCollector 
(#8067)
3367db446 is described below

commit 3367db446f5e354dba1c6eabb6f0e10495055626
Author: sstojak1 <18380216+sstoj...@users.noreply.github.com>
AuthorDate: Mon Sep 23 05:34:49 2024 +0200

    refactor: CollectAccounts now uses simple ApiCollector (#8067)
    
    Co-authored-by: Josip Stojak <josip.sto...@infobip.com>
---
 backend/plugins/sonarqube/tasks/accounts_collector.go | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/backend/plugins/sonarqube/tasks/accounts_collector.go 
b/backend/plugins/sonarqube/tasks/accounts_collector.go
index a6e3f67eb..6bb02272e 100644
--- a/backend/plugins/sonarqube/tasks/accounts_collector.go
+++ b/backend/plugins/sonarqube/tasks/accounts_collector.go
@@ -36,11 +36,7 @@ func CollectAccounts(taskCtx plugin.SubTaskContext) 
errors.Error {
        logger := taskCtx.GetLogger()
        logger.Info("collect accounts")
        rawDataSubTaskArgs, data := CreateRawDataSubTaskArgs(taskCtx, 
RAW_ACCOUNTS_TABLE)
-       collectorWithState, err := 
helper.NewStatefulApiCollector(*rawDataSubTaskArgs)
-       if err != nil {
-               return err
-       }
-       if err := collectorWithState.InitCollector(helper.ApiCollectorArgs{
+       collector, err := helper.NewApiCollector(helper.ApiCollectorArgs{
                RawDataSubTaskArgs: *rawDataSubTaskArgs,
                ApiClient:          data.ApiClient,
                PageSize:           100,
@@ -59,11 +55,12 @@ func CollectAccounts(taskCtx plugin.SubTaskContext) 
errors.Error {
                        err := helper.UnmarshalResponse(res, &resData)
                        return resData.Data, err
                },
-       }); err != nil {
+       })
+       if err != nil {
                return err
        }
 
-       return collectorWithState.Execute()
+       return collector.Execute()
 }
 
 var CollectAccountsMeta = plugin.SubTaskMeta{