This is an automated email from the ASF dual-hosted git repository.
lynwee pushed a commit to branch release-v1.0
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/release-v1.0 by this push:
new 981f3253b fix(tapd): fix overflow when converting lead time minutes
(#8244) (#8246)
981f3253b is described below
commit 981f3253b2190596feb41d7bf55e3ccc9751a055
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Wed Dec 18 15:33:18 2024 +0800
fix(tapd): fix overflow when converting lead time minutes (#8244) (#8246)
Co-authored-by: Lynwee <[email protected]>
---
backend/plugins/tapd/tasks/bug_converter.go | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/backend/plugins/tapd/tasks/bug_converter.go
b/backend/plugins/tapd/tasks/bug_converter.go
index 635b153dc..1ae6eaefe 100644
--- a/backend/plugins/tapd/tasks/bug_converter.go
+++ b/backend/plugins/tapd/tasks/bug_converter.go
@@ -18,6 +18,7 @@ limitations under the License.
package tasks
import (
+ "math"
"reflect"
"strconv"
"time"
@@ -88,8 +89,12 @@ func ConvertBug(taskCtx plugin.SubTaskContext) errors.Error {
results = append(results, issueAssignee)
}
if domainL.ResolutionDate != nil && domainL.CreatedDate
!= nil {
- temp :=
uint(domainL.ResolutionDate.Sub(*domainL.CreatedDate).Minutes())
- domainL.LeadTimeMinutes = &temp
+ durationInMinutes :=
domainL.ResolutionDate.Sub(*domainL.CreatedDate).Minutes()
+ // we have found some issues' ResolutionDate is
earlier than CreatedDate in tapd.
+ if durationInMinutes > 0 && durationInMinutes <
math.MaxUint {
+ temp := uint(durationInMinutes)
+ domainL.LeadTimeMinutes = &temp
+ }
}
boardIssue := &ticket.BoardIssue{
BoardId:
getWorkspaceIdGen().Generate(toolL.ConnectionId, toolL.WorkspaceId),
