caioq opened a new pull request, #8402:
URL: https://github.com/apache/incubator-devlake/pull/8402
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing
Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`,
`pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
This PR adds error handling for the database cursor in the
`StatefulApiExtractor` by checking for any error that might have occurred
during cursor iteration using `cursor.Err()`.
It ensures that any internal cursor error is not silently ignored and
properly propagated, improving the reliability and debuggability of the data
extraction process.
To support this, the `Err() error` method was added to the Rows interface,
allowing concrete cursor implementations to expose iteration errors.
### Does this close any open issues?
https://github.com/apache/incubator-devlake/issues/8198
https://github.com/apache/incubator-devlake/issues/7826
### Screenshots
### Other Information
This change was motivated by recurring but hard-to-diagnose errors such as
`unexpected EOF` and `busy buffer`, which have been observed during the
`extractIssues` step.
These errors do **not** appear in the downloadable pipeline logs, making
them difficult to trace, as they are only visible in the application logs.
By explicitly capturing `cursor.Err()`, this PR helps make such issues more
visible and traceable in standard pipeline output, improving the overall
observability and robustness of the extraction process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
