[ 
https://issues.apache.org/jira/browse/DL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439208#comment-15439208
 ] 

ASF GitHub Bot commented on DL-37:
----------------------------------

Github user leighst commented on a diff in the pull request:

    
https://github.com/apache/incubator-distributedlog/pull/15#discussion_r76433771
  
    --- Diff: 
distributedlog-service/src/main/java/com/twitter/distributedlog/service/stream/StreamImpl.java
 ---
    @@ -239,6 +231,12 @@ private DistributedLogManager openLog(String name) 
throws IOException {
         // Expensive initialization, only called once per stream.
         @Override
         public void initialize() throws IOException {
    +        try {
    +            sequencer = 
ReflectionUtils.newInstance(dynConf.getStreamSequencerClass());
    --- End diff --
    
    will you actually need this to be modified on the fly? 


> Add OffsetSequencer
> -------------------
>
>                 Key: DL-37
>                 URL: https://issues.apache.org/jira/browse/DL-37
>             Project: DistributedLog
>          Issue Type: Improvement
>          Components: distributedlog-core, distributedlog-service
>            Reporter: Khurrum Nasim
>             Fix For: 0.4.0
>
>
> In order to support kafka like offset, we'd like to introduce an offset 
> sequencer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to