[
https://issues.apache.org/jira/browse/DL-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483035#comment-15483035
]
Jia Zhai commented on DL-23:
----------------------------
[~JoshuaAndrew] [[email protected]] I made an attempt to change the thrift
version to 0.9.x in distributedlog-core and split the thrift and finagle
related protocol into distributedlog-service-protocol-thrift and
distributedlog-client-thrift. Let me know if this approach looks good to you
guys. If it is okay, I would continue and separate the thrift protocol out of
distributedlog-service.
after that we only have distributedlog-client-thrift and
distributedlog-service-thrift that depend on finagle-serversets and
libthrift-0.5.x. other modules will just depend on the central maven repo.
> Move distributedlog build to depend on central maven repo
> ---------------------------------------------------------
>
> Key: DL-23
> URL: https://issues.apache.org/jira/browse/DL-23
> Project: DistributedLog
> Issue Type: Improvement
> Components: distributedlog-client, distributedlog-core
> Reporter: Sijie Guo
>
> Reported https://github.com/twitter/distributedlog/issues/37.
> Currently they are a few dependencies only exists at maven.twttr. There are
> two major pieces, one is the finagle-serverset and while the other one is
> thrift library. The finagle-serverset is majorly used for service-discovery
> by distributedlog-client and thrift is used by scrooge and the rpc wire
> protocol between client and write proxy.
> There are two options:
> - one is to look for a solution to move those dependencies to central maven
> repo.
> - the other one is to see if we can make thrift and its service discovery
> pluginnable. so we can support both finagle-thrift and gRPC-protobuf.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
