qiaozhanwei commented on issue #1762: Refactor module URL: https://github.com/apache/incubator-dolphinscheduler/issues/1762#issuecomment-583941153 +1 1,common module duty not single,contains tool classes and business logic . so common module is only tool and service module is business logic. queue/quartz/zookeeper logic can put on service moudle 2,now It not necessary api server rely on dolphinscheduler-server moudle. for LoggerClient and quartz quote 1,common模块的职责不单一,其中包含了工具类和业务逻辑。所以common模块理论上应该就是去spring的工具类,service模块是处理业务逻辑的,比如说里面放定时逻辑,zk组件操作逻辑,LoggClient逻辑,等等。。。 2,现在dev分支上,api 模块是依赖 server模块的,这完全是没有必要的,但是由于引用了LoggerClient和定时的相关东西,所以得引用
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
