gabrywu opened a new issue #1929: [BUG] checkOtherParams unreasonable logic URL: https://github.com/apache/incubator-dolphinscheduler/issues/1929 The ProcessDefinitionService.checkProcessNodeList method has below codes: ` for (TaskNode taskNode : taskNodes) { if (!CheckUtils.checkTaskNodeParameters(taskNode.getParams(), taskNode.getType())) { logger.error("task node {} parameter invalid", taskNode.getName()); putMsg(result, Status.PROCESS_NODE_S_PARAMETER_INVALID, taskNode.getName()); return result; } // check extra params CheckUtils.checkOtherParams(taskNode.getExtras()); } ` What's the meaning of 'CheckUtils.checkOtherParams'? Should ‘CheckUtils.checkOtherParams’ throw an exception？ ` public static boolean checkTaskNodeParameters(String parameter, String taskType) { AbstractParameters abstractParameters = TaskParametersUtils.getParameters(taskType, parameter); if (abstractParameters != null) { return abstractParameters.checkParameters(); } return false; }`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
