dailidong commented on a change in pull request #2392: Add user information to
log
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/2392#discussion_r406819727
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
##########
@@ -93,8 +93,8 @@ public Result queryTaskListPaging(@ApiIgnore
@RequestAttribute(value = Constants
@RequestParam("pageSize") Integer
pageSize){
try{
- logger.info("query task instance list, project name:{},process
instance:{}, search value:{},task name:{}, executor name: {},state type:{},
host:{}, start:{}, end:{}",
- projectName, processInstanceId, searchVal, taskName,
executorName, stateType, host, startTime, endTime);
+ logger.info("login user {}, query task instance list, project
name:{},process instance:{}, search value:{},task name:{}, executor name:
{},state type:{}, host:{}, start:{}, end:{}",
Review comment:
User is an object, it's toString method will show many information, I want
to know do we need so many information?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
