kezhenxu94 commented on pull request #2733:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/2733#issuecomment-630168989


   > > The check script says that the dependency `commons-compiler-3.0.12.jar` 
is no longer included in the distribution packages, so please remove it from
   > > 
https://github.com/apache/incubator-dolphinscheduler/blob/1771aa50d5f00e30fd0ac1e166206c9e2b8e2001/tools/dependencies/known-dependencies.txt#L23
   > 
   > where does the scripts says? could you give a screenshot?
   
   See the attachment, the result of the script shows the differences between 
the declared dependencies and the **actual dependencies** in the distribution 
package, and it means `commons-compiler-3.0.12.jar` is not included in the 
final distribution package but is declared in the `known-dependencies`, 
therefore its license and notice(if any) should be removed from the 
LICENSE/NOTICE file
   
   <img width="1439" alt="image" 
src="https://user-images.githubusercontent.com/15965696/82215948-bdd98400-994a-11ea-80c7-59f8f4281510.png";>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to