ORuteMa commented on code in PR #14237:
URL:
https://github.com/apache/dolphinscheduler/pull/14237#discussion_r1210315301
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtils.java:
##########
@@ -164,12 +164,9 @@ public static List<String>
buildInitOptionsForSql(FlinkParameters flinkParameter
}
// yarn.application.queue
- String others = flinkParameters.getOthers();
- if (StringUtils.isEmpty(others) ||
!others.contains(FlinkConstants.FLINK_QUEUE)) {
- String queue = flinkParameters.getQueue();
- if (StringUtils.isNotEmpty(queue)) {
-
initOptions.add(String.format(FlinkConstants.FLINK_FORMAT_YARN_APPLICATION_QUEUE,
queue));
- }
+ String queue = flinkParameters.getQueue();
+ if (StringUtils.isNotEmpty(queue)) {
Review Comment:
The YARN queue should be assigned by property `yarn.application.queue`
rather than -yqu option, this option is not available in sql-client.sh. If we
want to specify the YARN queue used by a specific Flink SQL task, it would be
more appropriate to have an explicit queue option in the task submission form
rather than relying on parameters in the 'others' section. Regarding the naming
here, it is because in flink-run, the -yqu option only takes effect within the
-m option (for mode). When using the -t option (for target), it is necessary to
specify it using -Dyarn.application.queue=%s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
