github-code-scanning[bot] commented on code in PR #14355:
URL:
https://github.com/apache/dolphinscheduler/pull/14355#discussion_r1230407857
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-python/src/main/java/org/apache/dolphinscheduler/plugin/task/python/PythonTask.java:
##########
@@ -170,11 +170,11 @@
protected String buildPythonScriptContent() throws Exception {
log.info("raw python script : {}", pythonParameters.getRawScript());
String rawPythonScript =
pythonParameters.getRawScript().replaceAll("\\r\\n", System.lineSeparator());
- Map<String, Property> paramsMap =
mergeParamsWithContext(pythonParameters);
+ Map<String, Parameter> paramsMap =
mergeParamsWithContext(pythonParameters);
return ParameterUtils.convertParameterPlaceholders(rawPythonScript,
ParameterUtils.convert(paramsMap));
}
- protected Map<String, Property> mergeParamsWithContext(AbstractParameters
parameters) {
+ protected Map<String, Parameter> mergeParamsWithContext(AbstractParameters
parameters) {
Review Comment:
## Useless parameter
The parameter 'parameters' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/2977)
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -453,7 +453,7 @@
* @param rgex rgex
* @param sqlParamsMap sql params map
*/
- private void printReplacedSql(String content, String formatSql, String
rgex, Map<Integer, Property> sqlParamsMap) {
+ private void printReplacedSql(String content, String formatSql, String
rgex, Map<Integer, Parameter> sqlParamsMap) {
Review Comment:
## Useless parameter
The parameter 'rgex' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/2979)
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -453,7 +453,7 @@
* @param rgex rgex
* @param sqlParamsMap sql params map
*/
- private void printReplacedSql(String content, String formatSql, String
rgex, Map<Integer, Property> sqlParamsMap) {
+ private void printReplacedSql(String content, String formatSql, String
rgex, Map<Integer, Parameter> sqlParamsMap) {
Review Comment:
## Useless parameter
The parameter 'content' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/2978)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
