fatcarter opened a new issue, #14422:
URL: https://github.com/apache/dolphinscheduler/issues/14422

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   in `NettyClientHandler` class , has this code: 
   
   ```java
       /**
        * process received logic
        *
        * @param message command
        */
       private void processReceived(final Channel channel, final Message 
message) {
           ResponseFuture future = 
ResponseFuture.getFuture(message.getOpaque());
           if (future != null) {
               future.setResponseCommand(message);
               future.release();
               if (future.getInvokeCallback() != null) {
                   future.removeFuture();
                   this.callbackExecutor.submit(future::executeInvokeCallback);
               } else {
                   future.putResponse(message);
               }
           } else {
               processByCommandType(channel, message);
           }
       }
   ```
   Call method executeInvokeCallback when `getInvokeCallback != null`
   
   in ResponseFuture: 
   ```java 
   
       /**
        * put response
        *
        * @param responseMessage responseCommand
        */
       public void putResponse(final Message responseMessage) {
           this.responseMessage = responseMessage;
           this.latch.countDown();
           FUTURE_TABLE.remove(opaque);
       }
   ```
   
   `this.latch.countDown()` is called in ResponseFuture, why does 
future.getInvokeCallback()! = null does not need to be called
   
   
   
   ### What you expected to happen
   
   nothings
   
   ### How to reproduce
   
   nothings
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to