tongwl opened a new pull request, #14425:
URL: https://github.com/apache/dolphinscheduler/pull/14425
<!--Thanks very much for contributing to Apache DolphinScheduler, we are
happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
### Summary:
Fix the search bug on the page.
### Details：
Hi team, I am a frontend engineer from Cisco, our team is working on
secondary development based on the excellent product dolphinscheduler, and we
have been using it for nearly two years. During the process of providing it to
our customers, we have also discovered some bugs or optimization opportunities.
We would like to contribute these small cases to the community one by one if
possible.
**This pr is about the search bug in some pages, such as datasource, user
manage etc.**
I will use screenshots to demonstrate the bug on the user manage page.
1st step: You can see the first page has some emails which include word 'h':
<img width="1741" alt="image"
src="https://github.com/apache/dolphinscheduler/assets/13530192/7c7b4ac0-e265-43f2-85d2-3efaf0c53a61";>
2nd step: Change to last page, and enter the 'h' as the search text, enter
'Search' icon to search.
<img width="1714" alt="image"
src="https://github.com/apache/dolphinscheduler/assets/13530192/9b172f85-63ba-4b45-9a2c-1c6e2a471be9";>
3nd step:
<img width="984" alt="image"
src="https://github.com/apache/dolphinscheduler/assets/13530192/a3c6e8e9-e3f6-46f8-a4fe-029c0c9107c5";>
more:
Especially when there is data but only one page, it makes the user feel like
there is no data at all.
Due to the interaction between the search input box and pagination, there
are other UI bugs that may occur. Therefore, I referred to other pages without
problems and made a similar fix.
<img width="1723" alt="image"
src="https://github.com/apache/dolphinscheduler/assets/13530192/c1d0fefc-b002-4fb8-a81e-4001d7929274";>
Refer to other pages, just change to page = 1;
<img width="1026" alt="image"
src="https://github.com/apache/dolphinscheduler/assets/13530192/48cc2878-1340-477b-8b1b-28b1872eb091";>
Thanks, team.
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please
describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to
`docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
