rickchengx commented on code in PR #14504:
URL:
https://github.com/apache/dolphinscheduler/pull/14504#discussion_r1261898498
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/WorkerTaskKillProcessor.java:
##########
@@ -98,6 +96,7 @@ public void process(Channel channel, Message message) {
}
boolean result = doKill(taskExecutionContext);
+ this.cancelApplication(taskInstanceId);
Review Comment:
> I cannot reproduce this on my mac.
I think in some cases, `process.destroy` cannot kill the subprocess.
<img width="637" alt="截屏2023-07-13 10 12 39"
src="https://github.com/apache/dolphinscheduler/assets/38122586/384ce08a-40e3-46ce-8a2d-27ca08461a1e";>
https://stackoverflow.com/questions/5879791/how-to-kill-subprocesses-of-a-java-process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
