github-code-scanning[bot] commented on code in PR #14643:
URL:
https://github.com/apache/dolphinscheduler/pull/14643#discussion_r1275884325
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-obs/src/main/java/org/apache/dolphinscheduler/plugin/storage/obs/ObsStorageOperatorFactory.java:
##########
@@ -0,0 +1,29 @@
+//
+// Source code recreated from a .class file by IntelliJ IDEA
+// (powered by FernFlower decompiler)
+//
+
+package org.apache.dolphinscheduler.plugin.storage.obs;
+
+import org.apache.dolphinscheduler.plugin.storage.api.StorageOperate;
+import org.apache.dolphinscheduler.plugin.storage.api.StorageOperateFactory;
+import org.apache.dolphinscheduler.plugin.storage.api.StorageType;
+
+import com.google.auto.service.AutoService;
+
+@AutoService({StorageOperateFactory.class})
+public class ObsStorageOperatorFactory implements StorageOperateFactory {
+
+ public ObsStorageOperatorFactory() {
+ }
+
+ public StorageOperate createStorageOperate() {
+ ObsStorageOperator ossOperator = new ObsStorageOperator();
+ ossOperator.init();
+ return ossOperator;
+ }
+
+ public StorageType getStorageOperate() {
Review Comment:
## Missing Override annotation
This method overrides [StorageOperateFactory.getStorageOperate](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/3015)
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-obs/src/main/java/org/apache/dolphinscheduler/plugin/storage/obs/ObsStorageOperatorFactory.java:
##########
@@ -0,0 +1,29 @@
+//
+// Source code recreated from a .class file by IntelliJ IDEA
+// (powered by FernFlower decompiler)
+//
+
+package org.apache.dolphinscheduler.plugin.storage.obs;
+
+import org.apache.dolphinscheduler.plugin.storage.api.StorageOperate;
+import org.apache.dolphinscheduler.plugin.storage.api.StorageOperateFactory;
+import org.apache.dolphinscheduler.plugin.storage.api.StorageType;
+
+import com.google.auto.service.AutoService;
+
+@AutoService({StorageOperateFactory.class})
+public class ObsStorageOperatorFactory implements StorageOperateFactory {
+
+ public ObsStorageOperatorFactory() {
+ }
+
+ public StorageOperate createStorageOperate() {
Review Comment:
## Missing Override annotation
This method overrides [StorageOperateFactory.createStorageOperate](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/3016)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
