Radeity commented on code in PR #14702:
URL:
https://github.com/apache/dolphinscheduler/pull/14702#discussion_r1293625819
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/dependent/DependentAsyncTaskExecuteFunction.java:
##########
@@ -183,9 +192,16 @@ private List<DependentExecute>
initializeDependentTaskList() {
private DependResult calculateDependResult() {
List<DependResult> dependResultList = new ArrayList<>();
+ Map<String, Long> dependVarPoolEndTimeMap = new HashMap<>();
for (DependentExecute dependentExecute : dependentTaskList) {
DependResult dependResult =
dependentExecute.getModelDependResult(dependentDate,
processInstance.getTestFlag());
+ if (dependResult == DependResult.SUCCESS) {
+ Map<String, Property> varPoolPropertyMap =
dependentExecute.getDependTaskVarPoolPropertyMap();
+ Map<String, Long> varPoolEndTimeMap =
dependentExecute.getDependTaskVarPoolEndTimeMap();
+ dependentExecute.addTaskVarPool(varPoolPropertyMap,
varPoolEndTimeMap, dependVarPoolPropertyMap,
+ dependVarPoolEndTimeMap);
+ }
Review Comment:
> The use of dependVarPoolEndTimeMap is to obtain the data of
varPoolEndTimeMap in the addTaskVarPool method for the comparison of the
endTime of the subsequent loop
It seems that you just pass an empty map, maybe it's a different usage,
thus, define an util class do seems more clear.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/dependent/DependentAsyncTaskExecuteFunction.java:
##########
@@ -183,9 +192,16 @@ private List<DependentExecute>
initializeDependentTaskList() {
private DependResult calculateDependResult() {
List<DependResult> dependResultList = new ArrayList<>();
+ Map<String, Long> dependVarPoolEndTimeMap = new HashMap<>();
for (DependentExecute dependentExecute : dependentTaskList) {
DependResult dependResult =
dependentExecute.getModelDependResult(dependentDate,
processInstance.getTestFlag());
+ if (dependResult == DependResult.SUCCESS) {
+ Map<String, Property> varPoolPropertyMap =
dependentExecute.getDependTaskVarPoolPropertyMap();
+ Map<String, Long> varPoolEndTimeMap =
dependentExecute.getDependTaskVarPoolEndTimeMap();
+ dependentExecute.addTaskVarPool(varPoolPropertyMap,
varPoolEndTimeMap, dependVarPoolPropertyMap,
+ dependVarPoolEndTimeMap);
+ }
Review Comment:
> The use of dependVarPoolEndTimeMap is to obtain the data of
varPoolEndTimeMap in the addTaskVarPool method for the comparison of the
endTime of the subsequent loop
It seems that you just pass an empty map, maybe it's a different usage,
thus, define an util class do seems more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
