ruanwenjun commented on code in PR #15153:
URL: 
https://github.com/apache/dolphinscheduler/pull/15153#discussion_r1395778845


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/DaoConfiguration.java:
##########
@@ -61,6 +63,11 @@ public MybatisPlusInterceptor paginationInterceptor(DbType 
dbType) {
         return interceptor;
     }
 
+    @Bean
+    public DatabaseIdProvider databaseIdProvider() {
+        return new 
FixedDatabaseIdProvider(daoPluginConfiguration.databaseId());

Review Comment:
   Can we directly use daoPluginConfiguration.dbType().name() as databaseId?
   I find the databaseId only exist in `TriggerRelationMapper.xml` if we modify 
the name to `POSTGRE_SQL` this should work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to