Gallardot commented on code in PR #15303:
URL:
https://github.com/apache/dolphinscheduler/pull/15303#discussion_r1424891613
##########
.github/workflows/e2e-k8s.yml:
##########
@@ -47,11 +47,19 @@ jobs:
needs: paths-filter
if: ${{ (needs.paths-filter.outputs.not-ignore == 'true') ||
(github.event_name == 'push') }}
runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ '8', '11' ]
Review Comment:
> It seems we directly use mvnw for building image, which may not support
JDK11. I found that there is docker CLI in below steps. How about we use mvnw
for building jar, use Dockerfile for building image? Is there any policy in
apache against base docker image?
`mvnw` executes Docker CLI commands through a plugin.
There are two stages here. The host machine needs to be in a JDK11
environment when executing `mvnw` to build the jar file. When building the
Docker image, the base Docker image also needs to be JDK11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
