silentxingtian commented on PR #15772:
URL:
https://github.com/apache/dolphinscheduler/pull/15772#issuecomment-2021889438
> Hi @silentxingtian , how about this method?
>
> ```
> /**
> * grant project
> *
> * @param loginUser login user
> * @param userId user id
> * @param projectIds project id array
> * @return grant result code
> */
> @Override
> @Transactional
> public Map<String, Object> grantProject(User loginUser, int userId,
String projectIds) {
> Map<String, Object> result = new HashMap<>();
> result.put(Constants.STATUS, false);
> if (resourcePermissionCheckService.functionDisabled()) {
> putMsg(result, Status.FUNCTION_DISABLED);
> return result;
> }
> // check exist
> User tempUser = userMapper.selectById(userId);
> if (tempUser == null) {
> log.error("User does not exist, userId:{}.", userId);
> putMsg(result, Status.USER_NOT_EXIST, userId);
> return result;
> }
>
> ```
>
> Looks like not checking is admin too. Could you fix this?
ok, I will check all method and fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
