ruanwenjun commented on code in PR #15773:
URL:
https://github.com/apache/dolphinscheduler/pull/15773#discussion_r1544081744
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/taskgroup/TaskGroupCoordinator.java:
##########
@@ -198,10 +222,30 @@ private void dealWithForceStartTaskGroupQueue() {
// Find the force start task group queue(Which is inQueue and
forceStart is YES)
// Notify the related waiting task instance
// Set the taskGroupQueue status to RELEASE and remove it from queue
- List<TaskGroupQueue> taskGroupQueues =
taskGroupQueueDao.queryAllInQueueTaskGroupQueue()
- .stream()
- .filter(taskGroupQueue -> Flag.YES.getCode() ==
taskGroupQueue.getForceStart())
- .collect(Collectors.toList());
+ // We use limit here to avoid OOM, and we will retry to notify force
start queue at next time
+ int minTaskGroupQueueId = -1;
+ int limit = DEFAULT_LIMIT;
Review Comment:
A fixed value is ok, this config does not need to be exposed to the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
